Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added note about quarkus.native.container-build=true #27636

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Added note about quarkus.native.container-build=true #27636

merged 1 commit into from
Sep 2, 2022

Conversation

hbelmiro
Copy link
Contributor

@hbelmiro hbelmiro commented Aug 31, 2022 •
edited by geoand
Loading

This PR improves the documentation related to building native images.
Context: #27603 (comment)

@quarkus-bot

This comment was marked as resolved.

Sign in to view
@hbelmiro hbelmiro mentioned this pull request Aug 31, 2022
Closed
@geoand geoand requested a review from zakkak August 31, 2022 18:08
@geoand geoand changed the title Added note about quarkus.native.container-build=true to building-na… Added note about quarkus.native.container-build=true Sep 1, 2022
zakkak
zakkak approved these changes Sep 1, 2022
View reviewed changes
Copy link
Contributor

@zakkak zakkak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, but IMO it could be improved by adding a reference to the more detailed "tip" as mentioned in my comment.

Thanks

docs/src/main/asciidoc/building-native-image.adoc Show resolved Hide resolved
@hbelmiro hbelmiro force-pushed the docs-native-image-remote-container-build branch from a62086d to b352a42 Compare September 1, 2022 12:54
@geoand
Copy link
Contributor

geoand commented Sep 1, 2022

Mind squashing the commits please?

@hbelmiro hbelmiro force-pushed the docs-native-image-remote-container-build branch from b352a42 to 9938cef Compare September 1, 2022 14:48
@hbelmiro
Copy link
Contributor Author

hbelmiro commented Sep 1, 2022

@geoand commits squashed.

@geoand geoand added triage/waiting-for-ci Ready to merge when CI successfully finishes triage/backport? labels Sep 1, 2022
@geoand geoand merged commit e929b57 into quarkusio:main Sep 2, 2022
@quarkus-bot quarkus-bot bot added this to the 2.13 - main milestone Sep 2, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 2, 2022
@hbelmiro hbelmiro deleted the docs-native-image-remote-container-build branch September 2, 2022 10:04
@gsmet gsmet modified the milestones: 2.13 - main, 2.12.1.Final Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galderz galderz galderz approved these changes

@zakkak zakkak zakkak approved these changes

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/documentation
Projects
None yet
Milestone
2.12.1.Final
Development

Successfully merging this pull request may close these issues.
5 participants
@hbelmiro @geoand @galderz @zakkak @gsmet